Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to configure custom dnsConfig on the Nextcloud pod #594

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

nliechti
Copy link
Contributor

@nliechti nliechti commented Jul 23, 2024

Description of the change

The change allowes to configure dnsOptions on all nextcloud pods

Benefits

In some Clusters this option needs to be set. For example k3s clusters can have problems running alpine images.

Possible drawbacks

None

Applicable issues

Additional information

Checklist

@jessebot jessebot changed the title Add possibility to configure custom dnsConfig on the nextcloud images. Add possibility to configure custom dnsConfig on the Nextcloud pod Jul 23, 2024
@jessebot
Copy link
Collaborator

jessebot commented Jul 23, 2024

Awesome PR, @nliechti, thank you! Could you please bump the version in charts/nextcloud/Chart.yaml? Since this is a minor change that adds new functionality without impacting existing functionality, it's fine to use a minor version update, so 5.2.2 becomes 5.3.0. Then, I can approve the workflow and when the checks pass, we can get this merged :)

Signed-off-by: Niklas Liechti <[email protected]>
@jessebot jessebot self-assigned this Jul 24, 2024
@jessebot jessebot added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 24, 2024
@provokateurin provokateurin enabled auto-merge July 24, 2024 06:00
@provokateurin provokateurin merged commit ffea18f into nextcloud:main Jul 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants