Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default securityContext for nextcloud-metrics #558

Closed

Conversation

Tuxprogrammer
Copy link

Sets best defaults for securityContext on nextcloud-metrics pod and container.

Pull Request

Description of the change

Add defaults to the deployment of nextcloud-metrics with selections for securityContext options on both pod and container.

Benefits

Clusters with higher security configurations can run nextcloud with metrics enabled.

Possible drawbacks

Unknown, if any.

Applicable issues

  • fixes #

Additional information

Checklist

Sets best defaults for securityContext on nextcloud-metrics pod and container.

Signed-off-by: Spencer Callicott <[email protected]>
@Tuxprogrammer
Copy link
Author

related to #356

@jessebot
Copy link
Collaborator

jessebot commented Apr 30, 2024

These defaults should be set in the values.yaml and then templated into the metrics/deployment.yaml. Could you please do that so that users can customize what gets applied? Also, please bump the helm chart version.

@jessebot jessebot self-requested a review April 30, 2024 10:48
Copy link
Collaborator

@jessebot jessebot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see above comment

@jessebot jessebot added the 1. to develop Accepted and waiting to be taken care of label Jun 9, 2024
@jessebot jessebot added metrics anything to do with metrics gathering securityContext issues related security contexts labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of metrics anything to do with metrics gathering securityContext issues related security contexts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants