-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default securityContext for nextcloud-metrics #558
Closed
Tuxprogrammer
wants to merge
7
commits into
nextcloud:main
from
Tuxprogrammer:metrics-security-context
Closed
Set default securityContext for nextcloud-metrics #558
Tuxprogrammer
wants to merge
7
commits into
nextcloud:main
from
Tuxprogrammer:metrics-security-context
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets best defaults for securityContext on nextcloud-metrics pod and container. Signed-off-by: Spencer Callicott <[email protected]>
related to #356 |
These defaults should be set in the values.yaml and then templated into the metrics/deployment.yaml. Could you please do that so that users can customize what gets applied? Also, please bump the helm chart version. |
jessebot
requested changes
Jun 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see above comment
4 tasks
jessebot
added
metrics
anything to do with metrics gathering
securityContext
issues related security contexts
labels
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1. to develop
Accepted and waiting to be taken care of
metrics
anything to do with metrics gathering
securityContext
issues related security contexts
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets best defaults for securityContext on nextcloud-metrics pod and container.
Pull Request
Description of the change
Add defaults to the deployment of nextcloud-metrics with selections for securityContext options on both pod and container.
Benefits
Clusters with higher security configurations can run nextcloud with metrics enabled.
Possible drawbacks
Unknown, if any.
Applicable issues
Additional information
Checklist
Chart.yaml
according to semver.