Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace if with with (and improve strip using with -) #518

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

wrenix
Copy link
Collaborator

@wrenix wrenix commented Feb 2, 2024

Pull Request

Checklist

@wrenix wrenix force-pushed the chore/metrics branch 3 times, most recently from 52f5312 to 5b95eb7 Compare February 2, 2024 11:47
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think in a few places nindent is used where indent would be enough. Could you fix that?

@wrenix
Copy link
Collaborator Author

wrenix commented Feb 2, 2024

I am a hours away from keyboard, sry -> i believe there is needed, but i take a look

@wrenix wrenix marked this pull request as ready for review February 2, 2024 15:28
@wrenix
Copy link
Collaborator Author

wrenix commented Feb 4, 2024

you are correct, if i would not use in some places {{- toYaml, i could use indent instatt of nindent.
I often use it together with {{- with and {{- end`. so it looks for me nice on writing and reading.

that is a kind of personal preference. should i change it?

@provokateurin
Copy link
Member

I see, that makes sense. Then I prefer this style :) Still, it would be great to have a tool to enforce the style.

@wrenix
Copy link
Collaborator Author

wrenix commented Feb 4, 2024

increase chart-version after rebase

@provokateurin provokateurin merged commit 0ffea21 into nextcloud:main Feb 4, 2024
2 checks passed
@wrenix wrenix deleted the chore/metrics branch February 4, 2024 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants