Only set REDIS_HOST_PASSWORD when Redis auth is enabled #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the container's entrypoint, the configuration is messed up when Redis is used without authentication and the environment variable `REDIS_HOST_PASSWORD` is present (cf. https://github.com/nextcloud/docker/blob/master/docker-entrypoint.sh#L122). With the old setup, `REDIS_HOST_PASSWORD` will always be a string or an empty string which is not enough. Now the chart only sets `REDIS_HOST_PASSWORD` when `redis.auth.enabled` is `true`. Signed-off-by: mjdazz <[email protected]>
provokateurin
approved these changes
Oct 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description of the change
REDIS_HOST_PASSWORDis only set when Redis authentication is turned on.Benefits
Because of the container's entrypoint, Redis setup without authentication only works when the environment variable
REDIS_HOST_PASSWORDis not set at all (cf. https://github.com/nextcloud/docker/blob/master/docker-entrypoint.sh#L122). Previously, the chart only allowed for setting it as an empty string which is not enough and leads to a broken Redis connection string.Possible drawbacks
None I could think of.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.