Skip to content

Commit

Permalink
Include nextcloud service in trusted domains for metrics exporter (#483)
Browse files Browse the repository at this point in the history
* Include service in trusted domains for metrics

When nextcloud-exporter is used by enabling metrics, it fails to fetch
the serverinfo with 400 response code. This is related to the switch
from ingress to local service endpoint for nextcloud-exporter.
To fix this, in addition to .Values.nextcloud.host, the nextcloud
service also need to be included in the trusted domains.

Signed-off-by: Sunny <[email protected]>

* Update charts/nextcloud/templates/_helpers.tpl - use full service name and fix spacing for trusted domains

Co-authored-by: WrenIX <[email protected]>
Signed-off-by: JesseBot <[email protected]>

---------

Signed-off-by: Sunny <[email protected]>
Signed-off-by: JesseBot <[email protected]>
Co-authored-by: JesseBot <[email protected]>
Co-authored-by: WrenIX <[email protected]>
  • Loading branch information
3 people authored Jun 9, 2024
1 parent 5bde14f commit f8cf007
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/nextcloud/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: nextcloud
version: 4.6.10
version: 4.6.11
appVersion: 29.0.1
description: A file sharing server that puts the control and security of your own data back into your hands.
keywords:
Expand Down
2 changes: 1 addition & 1 deletion charts/nextcloud/templates/_helpers.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ Create environment variables used to configure the nextcloud container as well a
name: {{ .Values.nextcloud.existingSecret.secretName | default (include "nextcloud.fullname" .) }}
key: {{ .Values.nextcloud.existingSecret.passwordKey }}
- name: NEXTCLOUD_TRUSTED_DOMAINS
value: {{ .Values.nextcloud.host }}
value: {{ .Values.nextcloud.host }}{{ if .Values.metrics.enabled }} {{ template "nextcloud.fullname" . }}.{{ .Release.Namespace }}.svc.cluster.local{{ end }}
{{- if ne (int .Values.nextcloud.update) 0 }}
- name: NEXTCLOUD_UPDATE
value: {{ .Values.nextcloud.update | quote }}
Expand Down

0 comments on commit f8cf007

Please sign in to comment.