Apply suggestions from code review - properly exit on summary complet…

…ion and fix needs for summary Co-authored-by: Kate <[email protected]> Signed-off-by: Jesse Hitch <[email protected]>
nextcloud · Jul 23, 2024 · b08c352 · b08c352
1 parent 4f17410
commit b08c352
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/.github/workflows/lint-test.yaml b/.github/workflows/lint-test.yaml
@@ -115,7 +115,7 @@ jobs:
 
   summary:
     runs-on: ubuntu-latest-low
-    needs: changes
+    needs: [changes, run-tests]
     steps:
       - name: Summary
-        run: echo "All done! 🎉"
+        run: if ${{ needs.changes.outputs.src != 'false' && needs.run-tests.result != 'success' }}; then exit 1; fi