Skip to content

Commit

Permalink
pass in --set=fullnameOverride=nextcloud to ct command for S3 test, a…
Browse files Browse the repository at this point in the history
…nd fix up k8s Job for testing S3 to use curlimages/curl and properly use array items for /bin/sh and -c

Signed-off-by: jessebot <[email protected]>
  • Loading branch information
jessebot committed Jul 24, 2024
1 parent 356ce12 commit 96126a6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/test_upload_job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ spec:
spec:
containers:
- name: create-nextcloud-file
image: alpine
image: curlimages/curl
command:
- /bin/sh
- -c
- |
/bin/sh
-c
echo "testing123" > test_upload.txt && \
curl \
-u nextcloud:changeme \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ jobs:
# test the helm chart with s3 as the primary storage
- name: S3 Enabled as Primary Storage
# we need to skip the clean up so we can test adding a file
helm_args: '--namespace nextcloud --skip-clean-up --helm-extra-set-args "--set=nextcloud.objectStore.s3.enabled=true --set=nextcloud.objectStore.s3.accessKey=nextcloud --set=nextcloud.objectStore.s3.secretKey=rootpass123 --set=nextcloud.objectStore.s3.host=minio.minio.cluster.local.svc --set=nextcloud.objectStore.s3.port=9000 --set=nextcloud.objectStore.s3.bucket=nextcloud" && echo "Success 🎉"'
helm_args: '--namespace nextcloud --skip-clean-up --helm-extra-set-args "--set=fullnameOverride=nextcloud --set=nextcloud.objectStore.s3.enabled=true --set=nextcloud.objectStore.s3.accessKey=nextcloud --set=nextcloud.objectStore.s3.secretKey=rootpass123 --set=nextcloud.objectStore.s3.host=minio.minio.cluster.local.svc --set=nextcloud.objectStore.s3.port=9000 --set=nextcloud.objectStore.s3.bucket=nextcloud" && echo "Success 🎉"'

steps:
- name: Checkout
Expand Down

0 comments on commit 96126a6

Please sign in to comment.