Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Fix constructor of config class #1100

Merged
merged 3 commits into from
Jan 18, 2024

Conversation

nickvergessen
Copy link
Member

From nextcloud/server#41755

Makes at least the constructor pass again.

⚠️ This does not solve #1099 as the newly added functions still need to be overwritten.
But at least it does not break anymore

@nickvergessen nickvergessen added bug Something isn't working 3. to review Waiting for reviews labels Jan 16, 2024
@nickvergessen nickvergessen self-assigned this Jan 16, 2024
@nickvergessen
Copy link
Member Author

@icewind1991 we need to split master off from 28 it seems. Can you create a stable branch?

Signed-off-by: Robin Appelman <[email protected]>
@nickvergessen nickvergessen merged commit 4ea544d into master Jan 18, 2024
40 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/dont-break-hard branch January 18, 2024 16:26
@skjnldsv skjnldsv mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants