Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow infinite lock through configuration #55

Merged
merged 1 commit into from
Apr 30, 2022
Merged

Allow infinite lock through configuration #55

merged 1 commit into from
Apr 30, 2022

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 11, 2022 •
edited
Loading

Implements #49

  • Allow setting lock_timeout to 0 for not-expiring locks
  • Print out expiry details in the occ status command
  • Make no expiry the default

@juliusknorr juliusknorr added this to the 24 milestone Mar 11, 2022
@juliusknorr juliusknorr added the enhancement New feature or request label Mar 11, 2022
@juliusknorr juliusknorr mentioned this pull request Mar 11, 2022
Closed
@juliusknorr
Copy link
Member Author

Lock TTL would actually make sense to be adjustable depending on their use case.

  • WebDAV for example assumes that the lock initiator can specify the TTL
  • Collabora could actually use an infinite one, because WOPI will unlock files after they are out of use
  • For manual locks a default TTL would still make sense to avoid additional admin load on stale locks

@juliusknorr juliusknorr force-pushed the enh/allow-noexpire-locks branch from 5df44af to f4fda16 Compare March 24, 2022 11:22
julien-nc
julien-nc reviewed Mar 24, 2022
View reviewed changes
lib/Command/Lock.php Outdated Show resolved Hide resolved
lib/Model/FileLock.php Outdated Show resolved Hide resolved
@juliusknorr juliusknorr force-pushed the enh/allow-noexpire-locks branch from f4fda16 to 739fc17 Compare March 25, 2022 13:49
@juliusknorr juliusknorr requested a review from julien-nc March 25, 2022 13:50
@juliusknorr juliusknorr requested a review from Raudius April 19, 2022 16:50
@juliusknorr juliusknorr force-pushed the enh/allow-noexpire-locks branch from 53c6af9 to d32ce80 Compare April 30, 2022 14:40
@juliusknorr juliusknorr merged commit a1438cc into master Apr 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/allow-noexpire-locks branch April 30, 2022 14:40
@juliusknorr juliusknorr mentioned this pull request Nov 4, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@julien-nc julien-nc Awaiting requested review from julien-nc

@Raudius Raudius Awaiting requested review from Raudius

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @julien-nc