[stable27] fix: Preserve lock data in file info model #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
changed the title
juliusknorr
changed the title
When we obtain the model trough getModelForFile which reads the properties from the table row element, which does not preserve already fetched lock information otherwise. Signed-off-by: Julius Härtl <[email protected]>
juliusknorr
force-pushed
the
bugfix/noid/preserve-lock-data
branch
from
8b53f0b to
3150236
Compare
ArtificialOwl
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we obtain the model trough getModelForFile which reads the
properties from the table row element, which does not preserve already
fetched lock information otherwise.
This fixes disappearing lock information after leaving a document editor like Collabora where we update the file model based on the result of fileList.getModelForFile to indicate the last saved modification date update.
Note this is not a nice approach but the bug is solved by the clean API that the files app and files_lock use with 28 anyways.
Steps to reproduce:
before:
After: