Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Avoid re-query of already fetched lock info #196

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 16, 2023

We perform a query to cache file lock info for a directory listing, however the logic to get the lock info then in the prop find plugin still queried once per file as the cache was not propagated for files without lock.

Found when checking the most called queries on PMM

Screenshot 2023-12-16 at 10 34 40

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit I don't understand enough of the context to come up with a conclusive review.

I tried to comment what I understand and raised some questions. I hope that helps in clarifying the situation.

lib/Service/LockService.php Show resolved Hide resolved
lib/Service/LockService.php Show resolved Hide resolved
@juliusknorr juliusknorr merged commit c55649a into main Dec 19, 2023
26 checks passed
@juliusknorr juliusknorr deleted the perf/locks-queries branch December 19, 2023 15:12
@juliusknorr
Copy link
Member Author

/backport to stable27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants