Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix colours in dark mode #7755

Merged
merged 1 commit into from
Jan 31, 2025
Merged

fix colours in dark mode #7755

merged 1 commit into from
Jan 31, 2025
+13 −11

Conversation

nilsding
Copy link
Member

@nilsding nilsding commented Jan 15, 2025 •
edited
Loading

before after
Screenshot_20250115_134650 Screenshot_20250115_162358
Screenshot_20250115_135009 Screenshot_20250115_162729
Screenshot_20250115_154939 Screenshot_20250115_162848

(no idea why the icons are missing on the buttons on my Plasma setup, already reported in #7419)

@nilsding nilsding added the feature: ☁️ GUI System tray icon and menu. label Jan 15, 2025
@nilsding nilsding added this to the 3.16.0 milestone Jan 15, 2025
@nilsding nilsding self-assigned this Jan 15, 2025
@nilsding nilsding marked this pull request as ready for review January 16, 2025 08:58
@nilsding nilsding requested review from claucambra, mgallien and camilasan and removed request for claucambra and mgallien January 16, 2025 08:58
@nilsding nilsding force-pushed the bugfix/icons-darkmode branch from 42096b4 to eeb64bc Compare January 17, 2025 10:03
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7755-eeb64bc95ab7dd156b69466dd751a30b32b997a9-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@nilsding @mgallien
fix colours in dark mode
0ca7304 
- use placeholderText for TextField icons (introduced in Qt 5.12)
- use windowText for the large icons in activity view/search results
- also fix retrieval of icons from the server

Signed-off-by: Jyrki Gadinger <[email protected]>
@mgallien mgallien force-pushed the bugfix/icons-darkmode branch from eeb64bc to 0ca7304 Compare January 31, 2025 11:54
@mgallien mgallien enabled auto-merge January 31, 2025 11:58
@github-actions GitHub Actions
Copy link

Artifact containing the AppImage: nextcloud-appimage-pr-7755.zip

SHA256 checksum: d5cdab5d9ebb9201fc3dae25f1e9b64d9a7e973b96c816f8c736577c950a7233

To test this change/fix you can download the above artifact file, unzip it, and run it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
11 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@mgallien mgallien merged commit 2f2dadb into master Jan 31, 2025
13 of 16 checks passed
@mgallien mgallien deleted the bugfix/icons-darkmode branch January 31, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@claucambra claucambra Awaiting requested review from claucambra

Assignees

@nilsding nilsding

Labels
feature: ☁️ GUI System tray icon and menu.
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nilsding @nextcloud-desktop-bot @mgallien