Call setDesktopFileName without .desktop suffix
#7699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleifgch
force-pushed
the
fix-filename-warning
branch
from
dfbe64c to
eb09891
Compare
kleifgch
force-pushed
the
fix-filename-warning
branch
2 times, most recently
from
9bcd220 to
515df56
Compare
mgallien
approved these changes
Jan 2, 2025
As clarified in [1], the method expects to be called without the suffix. [1] qt/qtbase@0c5135a Signed-off-by: kleifgch <[email protected]>
mgallien
force-pushed
the
fix-filename-warning
branch
from
515df56 to
5d36070
Compare
|
/backport to stable-3.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7581
The motivation is explained in the issue.
I confirmed that this compiles and runs on my end,
but did not perform any other tests.