fix path of sync run log file #7659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikli
force-pushed
the
master
branch
2 times, most recently
from
0c44792 to
4bc73dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue #7654 where the old log location is used after moving the files to the new location on linux.
I have tested it locally and it seems to solve the problem, but I'm not really sure why the log should be stored in the config directory at all. If we want to solve this, we need to exclude the log files from the migration in
src/gui/application.cpp:L549and move the other log files in$XDG_CONFIG_DIR/Nextcloud/logsto the data directory.Please verify because I'm not very familiar with the code base of the nextcloud desktop client.