Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve definition of MIRALL_VERSION_SUFFIX and MIRALL_VERSION_BUILD #7625

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Dec 9, 2024

should allow ompiling with MIRALL_VERSION_SUFFIX be empty

@mgallien mgallien added this to the 3.15.1 milestone Dec 9, 2024
@mgallien
Copy link
Collaborator Author

mgallien commented Dec 9, 2024

/backport to stable-3.15

should allow ompiling with MIRALL_VERSION_SUFFIX be empty

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the ci/allowEmptyVersionSuffix branch from e842e03 to 6310e3e Compare December 11, 2024 10:07
@mgallien mgallien enabled auto-merge December 11, 2024 10:07
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
7 New Code Smells (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7625-6310e3e645386646b3613ecde4285875c1ff56d8-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 5f93204 into master Dec 11, 2024
13 of 16 checks passed
@mgallien mgallien deleted the ci/allowEmptyVersionSuffix branch December 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants