when locking a file set If-Match header to ensure etag is correct #7595
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgallien
force-pushed
the
bugfix/reliableLockRequests
branch
2 times, most recently
from
8bd97d0 to
4192f71
Compare
claucambra
approved these changes
Dec 6, 2024
the file being locked may have been changed sinc the client synced it so the server side file may have a modified etag. In such cases we do not want to lock the file and would rather sync the nex server changes before being able to lock the file that would ensure that on client side the file being locked is matching teh state of teh file on server side and would prevent inadvertently overriding server changes Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/reliableLockRequests
branch
from
4192f71 to
52e78b3
Compare
|
AppImage file: nextcloud-PR-7595-52e78b3ecef41d86b251a075e75bdfaa67cc48e4-x86_64.AppImage |
|
|
/backport to stable-3.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the file being locked may have been changed sinc the client synced it
so the server side file may have a modified etag. In such cases we do not want to lock the file and would rather sync the nex server changes before being able to lock the file
that would ensure that on client side the file being locked is matching teh state of teh file on server side and would prevent inadvertently overriding server changes