Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/narrow down permissions during sync #7532

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

@mgallien mgallien added this to the 3.15.0 milestone Nov 20, 2024
@mgallien mgallien force-pushed the bugfix/narrowDownPermissionsDuringSync branch 2 times, most recently from 2d43faa to 02029e8 Compare November 20, 2024 15:27
Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get the word "world" in the commit message, is that a term?

@mgallien mgallien force-pushed the bugfix/narrowDownPermissionsDuringSync branch from 02029e8 to a45e2e1 Compare November 21, 2024 10:52
@mgallien mgallien requested a review from camilasan November 21, 2024 10:53
@mgallien mgallien force-pushed the bugfix/narrowDownPermissionsDuringSync branch from a45e2e1 to de638f4 Compare November 21, 2024 10:54
a folder item must be set read-only if files or sub-folders cannot be
created

a folder item must be set read-write in all other situations

Signed-off-by: Matthieu Gallien <[email protected]>
past versions may have wrongly set the write permissions for other users
(UNIX style permissions)

remove this under the hypothesis that newly created files or folders
gets more restrictive permissions and that past files or folders should
be updated to get the same permissions

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the bugfix/narrowDownPermissionsDuringSync branch from de638f4 to 1417e8c Compare November 21, 2024 11:06
@mgallien mgallien merged commit 1e378a9 into master Nov 21, 2024
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/narrowDownPermissionsDuringSync branch November 21, 2024 11:07
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7532-1417e8cb60e84762f94345b21d587fb54bc90b51-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6 Security Hotspots
E Reliability Rating on New Code (required ≥ A)
1 New Bugs (required ≤ 0)
E Maintainability Rating on New Code (required ≥ A)
96 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants