Pull up the unified search view immediately on unified search field focus #7512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
requested review from
mgallien,
camilasan,
jancborchardt,
Rello,
marcoambrosini and
Hyeyoung346
marcoambrosini
approved these changes
Nov 19, 2024
jancborchardt
approved these changes
Nov 19, 2024
claucambra
force-pushed
the
bugfix/search-view-on-focus
branch
from
eb2bc59 to
cf1b1e2
Compare
mgallien
approved these changes
Nov 21, 2024
Signed-off-by: Claudio Cambra <[email protected]>
…n click elsewhere Signed-off-by: Claudio Cambra <[email protected]>
Do not activate search if the focus reason is tab as otherwise the user will never be able to access elements that depend on search being inactive via the keyboard Signed-off-by: Claudio Cambra <[email protected]>
…archFocus Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
…n focus and no text is entered Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
Signed-off-by: Claudio Cambra <[email protected]>
mgallien
force-pushed
the
bugfix/search-view-on-focus
branch
from
cf1b1e2 to
f7ae025
Compare
|
AppImage file: nextcloud-PR-7512-f7ae0254fcb480bd4106973a075e997f313bcb3e-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Depends on #7498
Replaces the activity view when the unified search field is focused