Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on setting folder permission on non-NTFS file systems on Windows #7487

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

Kaskadee
Copy link
Contributor

Adds an additional null check for resultDacl after calling GetSecurityDescriptorDacl since the value can be null for FAT32/exFAT file systems.

#7484

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@claucambra claucambra added this to the 3.14.5 milestone Nov 11, 2024
@claucambra
Copy link
Collaborator

/backport to stable-3.14

@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@mgallien mgallien force-pushed the bugfix/null-check-resultdacl branch from 5a70132 to f4480fe Compare November 14, 2024 18:19
@mgallien mgallien force-pushed the bugfix/null-check-resultdacl branch from f4480fe to 0f85a0b Compare November 15, 2024 08:28
@mgallien mgallien merged commit f6921ca into nextcloud:master Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants