Bugfix account removal #7426
Merged
Bugfix account removal #7426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
camilasan
commented
Oct 28, 2024
camilasan
commented
- When removing an account, an invalid 'user' was being saved in the config file
- Accounts were not fully removed: after removing an account, after restarting the client, the client would prompt the user to grant access again to the deleted account.
- Potentially this could fix the login issue where users get constantly prompted to grant access given that at some point their user was invalid (Account::retrieveAppPassword) => I couldn't reproduce this.
claucambra
approved these changes
Oct 29, 2024
The cookies are cleared when an account is removed, this call was bringing back the deleted account. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
camilasan
force-pushed
the
bugfix/accounts
branch
from
18b2a24 to
d080261
Compare
|
|
/backport to stable-3.14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.