Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.13] create a permanent log of delete actions #7380

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 22, 2024

Backport of #7028

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested review from claucambra and mgallien October 22, 2024 07:16
@backportbot backportbot bot added this to the 3.13.5 milestone Oct 22, 2024
@mgallien mgallien force-pushed the backport/7028/stable-3.13 branch 2 times, most recently from 117b545 to 8b4a3ad Compare October 22, 2024 11:05
@mgallien mgallien marked this pull request as ready for review October 22, 2024 11:12
will log all deletions with the result of the discovery by the sync
enginre

should enable analyze even long time after such a delete occured

Signed-off-by: Matthieu Gallien <[email protected]>
@claucambra claucambra force-pushed the backport/7028/stable-3.13 branch from 8b4a3ad to c44a711 Compare November 3, 2024 01:32
Copy link

sonarqubecloud bot commented Nov 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.5% Coverage on New Code (required ≥ 80%)
5 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@claucambra claucambra merged commit 1c547b8 into stable-3.13 Nov 3, 2024
9 of 13 checks passed
@claucambra claucambra deleted the backport/7028/stable-3.13 branch November 3, 2024 01:56
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7380-c44a71150fdb85e9978fb47ea6d027805c15ca04-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants