Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file tag fetching for files in sync folders that have non-root remote target #7375

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

claucambra
Copy link
Collaborator

No description provided.

@claucambra claucambra added the bug label Oct 21, 2024
@claucambra claucambra added this to the 3.14.3 milestone Oct 21, 2024
@claucambra claucambra self-assigned this Oct 21, 2024
@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
src/gui/folder.h Outdated Show resolved Hide resolved
src/gui/folder.h Outdated Show resolved Hide resolved
src/gui/filetagmodel.h Outdated Show resolved Hide resolved
@claucambra claucambra force-pushed the bugfix/filetag-fetching-path branch from 41f386f to ac3245d Compare November 21, 2024 07:33
@claucambra claucambra requested a review from mgallien November 21, 2024 07:40
@mgallien mgallien force-pushed the bugfix/filetag-fetching-path branch from bd59d7e to 7e37961 Compare November 21, 2024 07:42
@claucambra claucambra force-pushed the bugfix/filetag-fetching-path branch from 7e37961 to 175867d Compare November 21, 2024 07:51
…the particular local path

Fixes issues with users who are using remote non-root sync folders

Signed-off-by: Claudio Cambra <[email protected]>
This fixes the build breakages in the file tag model tests

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the bugfix/filetag-fetching-path branch from 175867d to 2769ae8 Compare November 21, 2024 08:57
@mgallien mgallien merged commit b421b35 into master Nov 21, 2024
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/filetag-fetching-path branch November 21, 2024 08:58
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7375-2769ae8a53030253911eb9f3da525011359d34a5-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants