Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QML errors caused by illegal customisation of text field backgrounds on native styles #7374

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

claucambra
Copy link
Collaborator

Fixes following errors:

2024-10-21 02:01:40:645 [ warning default qrc:/qml/src/gui/filedetails/ShareeSearchField.qml:53 ]:	qrc:/qml/src/gui/filedetails/ShareeSearchField.qml:53:17: QML QQuickRectangle: The current style does not support customization of this control (property: "background" item: QQuickRectangle(0x600001d42140, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference
2024-10-21 02:01:40:645 [ warning default qrc:/qml/src/gui/filedetails/NCInputTextField.qml:57 ]:	qrc:/qml/src/gui/filedetails/NCInputTextField.qml:57:17: QML QQuickRectangle: The current style does not support customization of this control (property: "background" item: QQuickRectangle(0x600001d42220, parent=0x0, geometry=0,0 0x0)). Please customize a non-native style (such as Basic, Fusion, Material, etc). For more information, see: https://doc.qt.io/qt-6/qtquickcontrols2-customize.html#customization-reference

@claucambra claucambra added this to the 3.14.3 milestone Oct 21, 2024
@claucambra claucambra self-assigned this Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
Fixes the following errors:

ShareeSearchField.qml:53:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42140, parent=0x0, geometry=0,0 0x0)).

NCInputTextField.qml:57:17: QML QQuickRectangle: The current style does
not support customization of this control (property: "background" item:
QQuickRectangle(0x600001d42220, parent=0x0, geometry=0,0 0x0)).

Signed-off-by: Claudio Cambra <[email protected]>
Fixes highlight of sharee search field with macOS styling

Signed-off-by: Claudio Cambra <[email protected]>
@mgallien mgallien force-pushed the bugfix/tf-backgrounds-issue branch from 3c983db to bcc968d Compare November 18, 2024 08:59
@mgallien mgallien merged commit 3e92a27 into master Nov 18, 2024
9 of 14 checks passed
@mgallien mgallien deleted the bugfix/tf-backgrounds-issue branch November 18, 2024 08:59
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7374-bcc968deb1350d77a4da2ebe2810c51d546d90ec-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants