Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix update channels #7350

Merged
merged 10 commits into from
Oct 31, 2024
Merged

Bugfix update channels #7350

merged 10 commits into from
Oct 31, 2024

Conversation

camilasan
Copy link
Member

I was just hoping to catch the issue of reports about it - like the channel changing without the user interaction.

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks otherwise looks good imo

src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
src/gui/settingsdialog.cpp Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the bugfix/updatechannels branch from 7d5db8e to 3eb582c Compare October 31, 2024 10:26
@camilasan
Copy link
Member Author

/backport to stable-3.14

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when built with BUILD_UPDATER=OFF, build failed as expected from my inline comment

src/gui/generalsettings.h Show resolved Hide resolved
src/libsync/account.cpp Outdated Show resolved Hide resolved
It should only return the value.

Signed-off-by: Camila Ayres <[email protected]>
Maintain stable and enterprise.

Signed-off-by: Camila Ayres <[email protected]>
… added or removed.

To give priority to server susbscriptions and keep listing the right update channels.

Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Only connect signal/slot for update channels listing when BUILD_UPDATER is ON.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan force-pushed the bugfix/updatechannels branch from 4c06e02 to 9b33cb5 Compare October 31, 2024 12:06
Copy link

sonarcloud bot commented Oct 31, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.4% Coverage on New Code (required ≥ 80%)
52 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7350-9b33cb5e0dc1cca89eae977d2b5f010c55851fc4-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit eb50768 into master Oct 31, 2024
11 of 15 checks passed
@mgallien mgallien deleted the bugfix/updatechannels branch October 31, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants