Bugfix/use file id to track renamed items #7334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.12 |
|
/backport to stable-3.13 |
|
/backport to stable-3.14 |
mgallien
force-pushed
the
bugfix/useFileIdToTrackRenamedItems
branch
from
6cf55b0 to
2cf7a0c
Compare
claucambra
approved these changes
Oct 17, 2024
why one would not update the modification time when modifying a remote file during automated tests there is no reason to not update the modification time as this is what is done by the server Signed-off-by: Matthieu Gallien <[email protected]>
NEW/NEW conflicts could sometime be ignored and replaced by update metadata instructions we stop doing this and handle them like any other conflicts that would cause more download from the server those conflicts would be solved automatically in case this is not a real conflict but the client was missing the server reply with the updated metadata will enable more changes to improve MOVE detection from server side Signed-off-by: Matthieu Gallien <[email protected]>
orignally added by owncloud/client#6632 most probably a too strong assumption on the behavior of the Nextcloud server better check real item metadata like fileid, size or modification time Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/useFileIdToTrackRenamedItems
branch
from
2cf7a0c to
05b6db5
Compare
This was referenced Oct 17, 2024
|
AppImage file: nextcloud-PR-7334-05b6db55c3da60366a05e00a7486309cdcdfc95e-x86_64.AppImage |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.