Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix authentication issues for macOS File Provider Extension #7240

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

claucambra
Copy link
Collaborator

Depends on claucambra/NextcloudFileProviderKit#22

Improve the authentication phase of the File Provider Extension by:

  • Verifying account details are correct before signalling the extension is ready to perform file operations
  • Reattempting authentication check if necessary due to bad connection
  • Adding timeouts for said authentication check to prevent server overloading
  • Properly using user and userId roles to fix LDAP authentication issues

Fixes #6783

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…nt rather than wrapping everything in task

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…ile Provider Extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…provider extension

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
@claucambra claucambra force-pushed the bugfix/mac-vfs-login-loop branch from e992f55 to 690303f Compare October 11, 2024 08:40
@claucambra claucambra merged commit b68da20 into master Oct 11, 2024
10 of 14 checks passed
@claucambra claucambra deleted the bugfix/mac-vfs-login-loop branch October 11, 2024 08:43
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7240-690303f952cff11db608ee9157eeead043769d18-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@claucambra
Copy link
Collaborator Author

/backport to stable-3.14

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App token login name does not match
4 participants