-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
properly detect and enable Qt6 WebEngine integration #7030
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this line also needs to be changed:
desktop/src/gui/CMakeLists.txt
Line 254 in 4233ea6
if (Qt${QT_MAJOR_VERSION}WebEngine_FOUND AND Qt${QT_MAJOR_VERSION}WebEngineWidgets_FOUND) |
On mac OS, as it is, it is not compiling. It could be something in my PATH too.
b574a16
to
2cdffdd
Compare
/backport to stable-3.14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm and it is compiling now on mac :)
Signed-off-by: Matthieu Gallien <[email protected]>
2cdffdd
to
7a979c7
Compare
AppImage file: nextcloud-PR-7030-7a979c732a936852cf6d8f720b61d2e4cd28b74f-x86_64.AppImage |
Quality Gate passedIssues Measures |
No description provided.