Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

properly detect and enable Qt6 WebEngine integration #7030

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

mgallien
Copy link
Collaborator

No description provided.

Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this line also needs to be changed:

if (Qt${QT_MAJOR_VERSION}WebEngine_FOUND AND Qt${QT_MAJOR_VERSION}WebEngineWidgets_FOUND)

On mac OS, as it is, it is not compiling. It could be something in my PATH too.

@mgallien mgallien force-pushed the ci/fixDetectionOfQt6WebEngineModule branch from b574a16 to 2cdffdd Compare August 27, 2024 12:02
@mgallien mgallien requested a review from camilasan August 27, 2024 12:08
@mgallien
Copy link
Collaborator Author

/backport to stable-3.14

Copy link
Member

@camilasan camilasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm and it is compiling now on mac :)

@mgallien mgallien force-pushed the ci/fixDetectionOfQt6WebEngineModule branch from 2cdffdd to 7a979c7 Compare August 28, 2024 09:35
@mgallien mgallien merged commit 347e5a9 into master Aug 28, 2024
10 of 14 checks passed
@mgallien mgallien deleted the ci/fixDetectionOfQt6WebEngineModule branch August 28, 2024 09:35
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7030-7a979c732a936852cf6d8f720b61d2e4cd28b74f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants