Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release kind detection #7024

Closed
wants to merge 1 commit into from
Closed

Conversation

ivaradi
Copy link
Contributor

@ivaradi ivaradi commented Aug 24, 2024

The changes last made to the Ubuntu/Debian build scripts do not work well on the stable branches, as it is not detected properly if we are dealing with a release or not. This patch fixes this problem.

@ivaradi ivaradi force-pushed the release_kind_fix branch 2 times, most recently from 313624f to fb63317 Compare August 26, 2024 04:42
@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 26, 2024

Hi @claucambra , thanks for the approval. However, as usual some of the checks are failing, and I cannot merge it. What is more annoying is that the Drone CI does not run, but this time it would be actually useful to see if my changes work in that environment too. Is there something you could do about it?

@claucambra
Copy link
Collaborator

Hi @claucambra , thanks for the approval. However, as usual some of the checks are failing, and I cannot merge it. What is more annoying is that the Drone CI does not run, but this time it would be actually useful to see if my changes work in that environment too. Is there something you could do about it?

Looks like there is a hold-up with drone

Could you sign-off the commit? This would fix the DCO check, thanks!

Signed-off-by: István Váradi <[email protected]>
@mgallien
Copy link
Collaborator

mgallien commented Aug 26, 2024

Hi @claucambra , thanks for the approval. However, as usual some of the checks are failing, and I cannot merge it. What is more annoying is that the Drone CI does not run, but this time it would be actually useful to see if my changes work in that environment too. Is there something you could do about it?

@ivaradi
for security reason, we cannot let drone run for branches from outside repositories (i.e. clones)
I think you have write access to this public repository, you can push your branch in it to let drone run over your PR

@ivaradi ivaradi closed this Aug 27, 2024
@ivaradi
Copy link
Contributor Author

ivaradi commented Aug 27, 2024

@ivaradi
for security reason, we cannot let drone run for branches from outside repositories (i.e. clones)
I think you have write access to this public repository, you can push your branch in it to let drone run over your PR

OK, I have created a new PR from a branch in this repository: #7031

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants