Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid wrong usage of QStringBuilder via auto type deduction #7017

Merged
merged 1 commit into from
Aug 22, 2024
Merged

avoid wrong usage of QStringBuilder via auto type deduction #7017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/gui/folder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
* or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* for more details.
*/
#include "common/syncjournaldb.h"

Check failure on line 16 in src/gui/folder.cpp

View workflow job for this annotation

GitHub Actions / build

src/gui/folder.cpp:16:10 [clang-diagnostic-error] 

'common/syncjournaldb.h' file not found
#include "config.h"

#include "account.h"
Expand Down Expand Up @@ -1481,8 +1481,8 @@
// Note: This assumes we're getting file watcher notifications
// for folders only on creation and deletion - if we got a notification
// on content change that would create spurious warnings.
const auto fullPath = _canonicalLocalPath + path;
const auto fullPath = QString{_canonicalLocalPath + path};
QFileInfo fi(fullPath);

Check warning on line 1485 in src/gui/folder.cpp

View workflow job for this annotation

GitHub Actions / build

src/gui/folder.cpp:1485:15 [readability-identifier-length] 

variable name 'fi' is too short, expected at least 3 characters
if (!FileSystem::fileExists(fullPath))
return;

Expand Down
2 changes: 1 addition & 1 deletion src/gui/proxyauthhandler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ void ProxyAuthHandler::handleProxyAuthenticationRequired(
}

const auto account = qobject_cast<Account *>(sender());
const auto key = proxy.hostName() + QLatin1Char(':') + QString::number(proxy.port());
const auto key = QString{proxy.hostName() + QLatin1Char(':') + QString::number(proxy.port())};

// If the proxy server has changed, forget what we know.
if (key != _proxy) {
Expand Down
Loading