Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep aspect ratio for thumbnails #6855

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

raldone01
Copy link
Contributor

@raldone01 raldone01 commented Jun 28, 2024

If someone wants cropped thumbnails this can be put behind an option in the settings but I see no use case for this.

Fixes: #6154

@raldone01 raldone01 force-pushed the fix/cropped_thumbnails branch from b619c83 to f76fef3 Compare June 28, 2024 16:09
@raldone01 raldone01 changed the title Fixes cropped thumbnails #6154 Keep aspect ratio for thumbnails Jun 28, 2024
@joshtrichards joshtrichards force-pushed the fix/cropped_thumbnails branch from f76fef3 to 20216af Compare August 16, 2024 01:19
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@mgallien mgallien force-pushed the fix/cropped_thumbnails branch from 20216af to e75d77c Compare August 20, 2024 13:15
@mgallien mgallien merged commit 3d9ed8a into nextcloud:master Aug 20, 2024
9 of 13 checks passed
@raldone01
Copy link
Contributor Author

raldone01 commented Sep 14, 2024

Mhh it seems to not have worked. I was unable to build the client under windows.

I have now setup a hyper-v ubuntu vm.
The build instructions are very outdated.
Here are current ones:

Setting up a build enviornment for nextcloud-desktop

  1. Install ubuntu noble (Ubuntu 24.04.1 LTS)
  • At least 8GB RAM otherwise oom when building
  • At least 70GB of storage
  1. Setup apt to allow the install of oracular packages

/etc/apt/preferences.d/zubuntu_oracular

Package: *
Pin: release n=oracular
Pin-Priority: 1

/etc/apt/sources.list.d/zubuntu_oracular.sources

Types: deb
URIs: http://archive.ubuntu.com/ubuntu/
Suites: oracular oracular-updates oracular-backports
Components: main restricted universe multiverse
Signed-By: /usr/share/keyrings/ubuntu-archive-keyring.gpg
  1. Install the build dependencies with apt
sudo apt update
sudo apt install -t oracular cmake extra-cmake-modules g++ inkscape \
sphinx libcmocka-dev \
doxygen graphviz \
dolphin libkf6kio-dev \
openssl libssl-dev libzip-dev sqlite3 libsqlite3-dev zlib1g-dev shared-mime-info \
qt6-base-dev qt6-base-private-dev qt6-5compat-dev \
libkf6guiaddons-dev libkf6archive-dev libkf6archive-doc libkf6archive6 \
qt6-declarative-private-dev qt6-declarative-dev qt6-declarative-dev-tools \
qt6-webengine-dev qt6-webengine-dev-tools qt6-webengine-private-dev \
qt6-tools-dev qt6-tools-private-dev qt6-tools-dev-tools \
libqt6websockets6 qt6-websockets-dev qt6-websockets-private-dev \
qtquickcontrols2-5-dev qtquickcontrols2-5-private-dev \
qtkeychain-qt6-dev qt6-svg-dev \
texlive-latex-base texlive-fonts-recommended texlive-fonts-extra texlive-latex-extra
  1. Build and install
$ git clone https://github.com/nextcloud/desktop.git
$ cd desktop
$ cmake -S . -B build -DCMAKE_INSTALL_PREFIX=~/nextcloud-desktop-client -DCMAKE_BUILD_TYPE=Debug
$ sudo cmake --build build --target install -j $(nproc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Files Previews / Thumbnails Cropped in Windows Explorer
3 participants