Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use windows-2022 image to run our windows CI on github actions #6705

Merged
merged 11 commits into from
May 15, 2024

Conversation

mgallien
Copy link
Collaborator

also switch craft to target windows-msvc2022_64-cl

@mgallien mgallien force-pushed the ci/fixWindowsCi branch 10 times, most recently from efd39dd to d1dd966 Compare May 2, 2024 14:40
@mgallien mgallien force-pushed the ci/fixWindowsCi branch 5 times, most recently from b2795c5 to ee28255 Compare May 14, 2024 09:52
mgallien and others added 9 commits May 15, 2024 15:06
also switch craft to target windows-msvc2022_64-cl

Signed-off-by: Matthieu Gallien <[email protected]>
Signed-off-by: Matthieu Gallien <[email protected]>
should avoid triggering implicit hydration from within the desktop
client

triggering an implicit hydration on our own is strictly forbidden as
that is causing issues like deadlock and failed hydration attempts

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien enabled auto-merge May 15, 2024 13:06
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6705-a3083f8be4fc064705a47d702ce00c32230976cf-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
31 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien merged commit 42ed8b4 into master May 15, 2024
10 of 13 checks passed
@mgallien mgallien deleted the ci/fixWindowsCi branch May 15, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants