Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix. E2EE. Always migrate from 1.2 to 2.0, even with nested folders. #6695

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander
Copy link
Contributor Author

We have an issue with old E2EE folders (version < 2.0) if there are nested folders inside those and the user makes a change in the nested folder. The encrypted folder then becomes broken as the nested folder + root E2EE folder relation is getting messed up. We already have a code for proper migration. We did not enable it for folders with nested folders for some reason of mobile client limitations. But this is the proper way to do it on a desktop and prevents issues with using such old folders later.

This is probably the problem some users are still suffering in nextcloud/ios#2809.

@tobiasKaminsky I think we should enable automatic migration for E2EE folders with nested folders on desktop.

@allexzander
Copy link
Contributor Author

/backport to stable-3.13

@allexzander
Copy link
Contributor Author

/backport to stable-3.12

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you have a look at adding automated tests via the end-to-end tests with a real running server ?
@tobiasKaminsky in the end up to you if Alex has time to add those automated tests

@mgallien mgallien force-pushed the bugfix/migration-1.2-to-2.0-nestedfolders branch from d9eb463 to 25a6219 Compare May 21, 2024 16:53
@mgallien mgallien force-pushed the bugfix/migration-1.2-to-2.0-nestedfolders branch from 25a6219 to 0f87fd4 Compare May 22, 2024 08:42
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6695-0f87fd4a715b975df7431f41778faaceb17ca7d6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented May 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
46 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants