Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add daily update channel. #6658

Merged
merged 16 commits into from
Jul 3, 2024
Merged

Add daily update channel. #6658

merged 16 commits into from
Jul 3, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Apr 22, 2024

Client updater: nextcloud/client_updater_server#144
Infrastructure: https://github.com/nextcloud-gmbh/internal-infrastructure/pull/416

  • Adds the daily and enterprise option to the update url:
    channel=daily

  • Changes the message box test when the user switches update channels:

    • before:
      update-channel-before
    • after:
      update-channel-after
  • Test:

    • Linux
    • mac OS
    • Windows
  • ⚠️ The updater site backend part needs to be implement

@camilasan camilasan marked this pull request as ready for review April 23, 2024 17:58
@camilasan camilasan marked this pull request as draft April 23, 2024 18:04
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan force-pushed the feature/update-channel branch 2 times, most recently from fca12f6 to a133d1a Compare June 3, 2024 19:14
@camilasan camilasan marked this pull request as ready for review June 3, 2024 19:14
@camilasan camilasan force-pushed the feature/update-channel branch 2 times, most recently from 180edbe to 031319f Compare June 3, 2024 19:25
This was referenced Jun 3, 2024
@camilasan camilasan changed the title Add new update channels. Add daily update channels. Jun 3, 2024
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement! :) Love the bullet points, they make things so much more clear. The wording is also way more concise!
I would suggest only a few minor changes

- stable: contains tested versions considered reliable
- beta: contains versions with new features that may not be tested thoroughly
- daily: contains versions created daily only for testing and development

Downgrading versions is not possible immediately: changing from beta to stable means waiting for the new stable version.

As a follow up, I would propose some more changes:

  • on the settings page, the channels could be in radio buttons instead of in a dropdown.
  • that way we could move the channel info directly onto the settings page
  • change the confirmation dialog to show only the "downgrading is not possible" message
  • show the confirmation dialog only when changing from daily to beta or beta to stable

What do you think :)

@tobiasKaminsky tobiasKaminsky linked an issue Jun 4, 2024 that may be closed by this pull request
@Mika-6-9
Copy link

Mika-6-9 commented Jun 4, 2024

It's a really good idea, why only tests on Linux?
We can test on Windows if you need testers.

How will the enterprise (stable) versions be validated?

@camilasan camilasan force-pushed the feature/update-channel branch from 031319f to 13b0d9e Compare June 26, 2024 19:33
@camilasan
Copy link
Member Author

camilasan commented Jun 27, 2024

* that way we could move the channel info directly onto the settings page

where would the text go?

@nimishavijay
Copy link
Member

@camilasan looks great! I would only recommend that it's in a vertical arrangement instead of horizontal :)

@camilasan camilasan force-pushed the feature/update-channel branch from 13b0d9e to 7b05000 Compare July 2, 2024 12:28
@camilasan camilasan changed the title Add daily update channels. Add daily update channel. Jul 2, 2024
@camilasan
Copy link
Member Author

@camilasan looks great! I would only recommend that it's in a vertical arrangement instead of horizontal :)

I will address this in #6873

src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
src/gui/updater/updater.cpp Outdated Show resolved Hide resolved
src/libsync/configfile.cpp Outdated Show resolved Hide resolved
camilasan added 5 commits July 3, 2024 16:32
- Set update channel options list in slotUpdateInfo.

Signed-off-by: Camila Ayres <[email protected]>
…channel.

- Also makes the explanation more concise.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan force-pushed the feature/update-channel branch from 0b87344 to 4de3107 Compare July 3, 2024 14:32
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6658-4de310738309b8b61c9495674f00966fd968689a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link

sonarcloud bot commented Jul 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
20 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan merged commit ba9b340 into master Jul 3, 2024
12 of 14 checks passed
@camilasan camilasan deleted the feature/update-channel branch July 3, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Daily channel
5 participants