Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests #6596

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Fix tests #6596

merged 3 commits into from
Apr 22, 2024

Conversation

pyromaniac2k
Copy link
Contributor

The first two changes allow to run tests within a network sandbox, the third fixes a time zone DST change issue

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks good, I will run the CI and see if anything breaks :)

LocalHost is enough to complete the tests, and it enables the test to be
run under networksandboxing.

Signed-off-by: Thomas Witt <pyromaniac@exherbo.org>
Using the real account state needs an internet connection.

Additionally, `example.de` is a valid existing domain, which should
probably not be used in testing. Switching to `example.com` as this is
recommended here.

Signed-off-by: Thomas Witt <pyromaniac@exherbo.org>
This test fails on the day before a timezone switch:
   Actual   (model.clearAtDisplayString()): "23 hours"
   Expected (tr("1 day"))                 : "1 day"

Setting the timezone to UTC remedies this problem.

Signed-off-by: Thomas Witt <pyromaniac@exherbo.org>
@mgallien mgallien merged commit b7dd6ff into nextcloud:master Apr 22, 2024
8 of 11 checks passed
@mgallien mgallien added this to the 3.14.0 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants