E2EE. Fix root metadata fetching path for non-root remote sync folder. Refactoring. Stabilizing paths.

[allexzander]

No description provided.

[allexzander]

Yes. Again, lots of similar changes for dealing with non-root remote sync root paths. Due to the new way of fetching metadata (keys are stored in the root folder's metadata). Extensive manual tests were successful. What we are really missing is end-to-end testing. Otherwise, we are going to continue fixing regressions.

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[allexzander]

/backport to stable-3.12

[mgallien]

please add automated tests for such cases
would be needed to ensure this code can become more reliable

[allexzander]

please add automated tests for such cases would be needed to ensure this code can become more reliable

How do you propose to implement these tests? The e2e-to-end encryption interaction between client and server is way too complicated to implement unit tests for it. This requires writing most of the endpoints the server is using for E2EE, not just simple PROPFIND. We do not have framework for such testing for this reason.

This type of tests require different testing approach, called end-to-end testing (or QA automation), for which, we do not have capacity.

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-6529-c5dd2e89a1c7abe5a5ac67ce05bfdcb9e7b6b40b-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Quality Gate failed

Failed conditions
1 Security Hotspot
14.6% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
183 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint