Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use a longer maximum timeout during chunk uploads #6513

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

use a longer maximum timeout during chunk uploads #6513

wants to merge 1 commit into from
+4 −6

Conversation

mgallien
Copy link
Collaborator

@mgallien mgallien commented Mar 6, 2024

Close #5394

@mgallien mgallien marked this pull request as ready for review March 6, 2024 10:26
@mgallien mgallien force-pushed the bugfix/chunkUploadWaitLongerTimeout branch from 21ee568 to 409689b Compare March 6, 2024 12:10
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mgallien mgallien force-pushed the bugfix/chunkUploadWaitLongerTimeout branch from 409689b to 360c753 Compare April 23, 2024 12:57
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6513-360c7533d5dbde2496f471b0bc71a6e4aac62533-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)
3 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

claucambra
claucambra requested changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgallien I am guessing we still want this? Unfortunately has merge conflicts now

@claucambra claucambra added this to the 3.14.2 milestone Oct 11, 2024
@Rello Rello modified the milestones: 3.14.2, 3.14.3 Oct 18, 2024
@claucambra claucambra modified the milestones: 3.14.4, 3.14.5 Nov 3, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@mgallien
Copy link
Collaborator Author

@mgallien I am guessing we still want this? Unfortunately has merge conflicts now

there is also the issue that we had problems with our timeout handling code when moving to Qt6
so this cannot be merged right now
moving to the next milestone

@mgallien mgallien modified the milestones: 3.15.0, 3.16.0 Nov 19, 2024
@mgallien mgallien marked this pull request as draft November 29, 2024 13:04
@mgallien
Copy link
Collaborator Author

this is needed but blocked by a regression with timeout in master branch
let's keep it open for some time before we would close it if there is no progress on timeout hnalding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra requested changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.16.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Large File Synchronizations Fail due to Hardcoded Timeout Value in Desktop Client
4 participants
@mgallien @nextcloud-desktop-bot @claucambra @Rello