Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmake NEXTCLOUD_DEV so debug client can run in parallel to release client. #6472

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Add cmake NEXTCLOUD_DEV so debug client can run in parallel to release client. #6472

merged 1 commit into from
Apr 11, 2024

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Feb 20, 2024 •
edited
Loading

It needs testing:

  • Windows
  • mac OS

mgallien
mgallien approved these changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool
so nice
so cleaner than what I had been using

claucambra
claucambra requested changes Feb 21, 2024
View reviewed changes
NEXTCLOUD.cmake Outdated Show resolved Hide resolved
mgallien
mgallien requested changes Feb 21, 2024
View reviewed changes
src/libsync/logger.cpp Outdated Show resolved Hide resolved
claucambra
claucambra reviewed Feb 21, 2024
View reviewed changes
NEXTCLOUD.cmake Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@camilasan
Copy link
Member Author

/rebase

@camilasan camilasan enabled auto-merge (rebase) April 11, 2024 12:29
@camilasan @mgallien
Add cmake NEXTCLOUD_DEV so debug client can run in parallel to releas…
63b0a9f 
…e client.

- Defaults to OFF.

Signed-off-by: Camila Ayres <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6472-63b0a9f94de46f4fbfcfb667b3f3424fe9640abb-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mgallien mgallien disabled auto-merge April 11, 2024 16:43
@mgallien mgallien merged commit d6ed678 into master Apr 11, 2024
11 of 13 checks passed
@mgallien mgallien deleted the nextcloud-dev branch April 11, 2024 16:43
@mgallien mgallien added this to the 3.14.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra requested changes

@mgallien mgallien mgallien approved these changes

@allexzander allexzander Awaiting requested review from allexzander

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.14.0
Development

Successfully merging this pull request may close these issues.
4 participants
@camilasan @nextcloud-desktop-bot @mgallien @claucambra