Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/detect open files #6434

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Feature/detect open files #6434

merged 1 commit into from
Feb 14, 2024

Conversation

allexzander
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot requested changes Feb 10, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/common/utility_win.cpp Show resolved Hide resolved
@allexzander allexzander marked this pull request as ready for review February 10, 2024 19:51
@allexzander allexzander force-pushed the feature/detect-open-files branch from a166da3 to 3d20058 Compare February 12, 2024 09:10
mgallien
mgallien requested changes Feb 12, 2024
View reviewed changes
src/libsync/discovery.cpp Outdated Show resolved Hide resolved
@allexzander allexzander requested a review from mgallien February 12, 2024 19:24
@allexzander allexzander force-pushed the feature/detect-open-files branch 2 times, most recently from 3375b4b to 6508fce Compare February 13, 2024 10:45
@allexzander allexzander requested a review from mgallien February 13, 2024 11:08
@allexzander @mgallien
Do not upload modified PDF file while it is open in Kofax PowerPDF on…
b2aca21 
… Windows. Prevents signature verification failure.

Signed-off-by: alex-z <[email protected]>
@mgallien mgallien force-pushed the feature/detect-open-files branch from 6508fce to b2aca21 Compare February 14, 2024 07:25
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6434-b2aca219fcbcdac04fa0088b1fee900fcc958062-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
34.3% Coverage on New Code (required ≥ 80%)
17 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@allexzander
Copy link
Contributor Author

/backport to stable-3.12

@allexzander allexzander merged commit e2410ff into master Feb 14, 2024
10 of 13 checks passed
@allexzander allexzander deleted the feature/detect-open-files branch February 14, 2024 08:40
@backportbot backportbot bot mentioned this pull request Feb 14, 2024
Merged
@Mika-6-9
Copy link

Hi.
I have a question, why do we see "PowerPDF.exe" associated with the .pdf extension in the code? Will PDF opening detection only work with this software?

@allexzander
Copy link
Contributor Author

@Mika-6-9 Yes, only Kofax PowerPDF.

@Mika-6-9
Copy link

@allexzander Hi, thank you for the answer.
Why only this software?
Can't we have detection for all PDF editing software?
Or at least for using the default PDF viewer?
This function would be very interesting

@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] requested changes

@mgallien mgallien mgallien approved these changes

@claucambra claucambra Awaiting requested review from claucambra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @nextcloud-desktop-bot @Mika-6-9 @mgallien