Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve how the UI shows that the client is actually syncing #6423

Closed
wants to merge 22 commits into from
Closed

Improve how the UI shows that the client is actually syncing #6423

wants to merge 22 commits into from

Conversation

camilasan
Copy link
Member

sincying

What do you think @nextcloud/designers?

@camilasan camilasan force-pushed the bugfix/network-errors branch from e6c6c77 to ed4b52d Compare February 7, 2024 21:29
@camilasan camilasan marked this pull request as ready for review February 7, 2024 21:30
@szaimen
Copy link
Contributor

szaimen commented Feb 9, 2024

What do you think @nextcloud/designers?

How did it look before?

@camilasan camilasan force-pushed the bugfix/network-errors branch from ed4b52d to b0313e9 Compare February 9, 2024 19:49
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
10.3% Coverage on New Code (required ≥ 80%)
54 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@mgallien mgallien mentioned this pull request Feb 13, 2024
Merged
@camilasan
Copy link
Member Author

camilasan commented Feb 27, 2024 •
edited
Loading

What do you think @nextcloud/designers?

How did it look before?

there is not third status line showing details.

before

in this change, the text in 'alt' is printed next to the icon:
alt-text

claucambra
claucambra reviewed Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise looks good

I'm not a designer but the root folder status item looks like it could use some more bottom padding to match the top padding

src/gui/application.cpp Show resolved Hide resolved
@camilasan camilasan force-pushed the bugfix/network-errors branch from 0441237 to 919d9a0 Compare April 2, 2024 09:08
@camilasan
Copy link
Member Author

Jan's feedback: "Checking new files …" seems good. "Please wait" is very generic and not helpful so we should never use that. :) => to show when there seems to be nothing to report
Regarding the change, is it possible we simplify it a little bit so we only have 1 instead of 2 sublines? It is very very complex with 2, could we instead only have:
"Syncing [filename], file 2 of 200, 3 GB of 200 GB, 53 minutes left"?
And the rest like Mbps etc can go into the tooltip?

@camilasan camilasan force-pushed the bugfix/network-errors branch from 919d9a0 to db6bf9a Compare April 11, 2024 07:40
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6423-db6bf9a288f86fd050c4c78862e8acd10653816f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
11.7% Coverage on New Code (required ≥ 80%)
D Maintainability Rating on New Code (required ≥ A)
87 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@camilasan camilasan force-pushed the bugfix/network-errors branch from db6bf9a to 1e953f0 Compare April 24, 2024 13:33
@camilasan camilasan changed the base branch from master to stable-3.12 April 24, 2024 13:33
@camilasan camilasan marked this pull request as draft April 24, 2024 13:33
@camilasan
Copy link
Member Author

I am using stable-3.12 for now as a base.

mgallien and others added 10 commits June 17, 2024 15:30
@mgallien @camilasan
starts the development of version 3.13
8b5967e 
Signed-off-by: Matthieu Gallien <[email protected]>
@nextcloud-bot @camilasan
Fix(l10n): Update translations from Transifex
034f6bb 
Signed-off-by: Nextcloud bot <[email protected]>
@dependabot @camilasan
Build(deps): Bump peter-evans/create-or-update-comment
c8a89b5 
Bumps [peter-evans/create-or-update-comment](https://github.com/peter-evans/create-or-update-comment) from 3.1.0 to 4.0.0.
- [Release notes](https://github.com/peter-evans/create-or-update-comment/releases)
- [Commits](peter-evans/create-or-update-comment@23ff157...71345be)

---
updated-dependencies:
- dependency-name: peter-evans/create-or-update-comment
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@nextcloud-bot @camilasan
Fix(l10n): Update translations from Transifex
40cd558 
Signed-off-by: Nextcloud bot <[email protected]>
@nextcloud-bot @camilasan
Fix(l10n): Update translations from Transifex
348ced0 
Signed-off-by: Nextcloud bot <[email protected]>
@skjnldsv @camilasan
chore: update workflows from templates
b64933d 
Signed-off-by: John Molakvoæ <[email protected]>
@dependabot @camilasan
Build(deps): Bump codecov/codecov-action from 3 to 4
7bc8c3b 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3 to 4.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v3...v4)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@claucambra @camilasan
Run swift-format on swift code
b38ee48 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @camilasan
Add .swift-format.json
3111cb6 
Signed-off-by: Claudio Cambra <[email protected]>
@claucambra @camilasan
Clean up file provider extension property declarations and init
939e9e4 
Signed-off-by: Claudio Cambra <[email protected]>
claucambra and others added 12 commits June 17, 2024 15:30
@claucambra @camilasan
Cllean up function and method calls in File Provider Extension
94c7fc0 
Signed-off-by: Claudio Cambra <[email protected]>
@nextcloud-bot @camilasan
Fix(l10n): Update translations from Transifex
449f48d 
Signed-off-by: Nextcloud bot <[email protected]>
@nextcloud-bot @camilasan
Fix(l10n): Update translations from Transifex
ac12372 
Signed-off-by: Nextcloud bot <[email protected]>
@nextcloud-bot @camilasan
Fix(l10n): Update translations from Transifex
7555f33 
Signed-off-by: Nextcloud bot <[email protected]>
@camilasan
Show details of the syncing progress in the settings dialog.
78e8b83 
Before it was only shown in the tooltip.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Modernize FolderStatusModel::slotSetProgress.
347ba08 
- Add const auto.
- Change variable names to be more clear.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add logs.
537ad9a 
Signed-off-by: Camila Ayres <[email protected]>
@mgallien @camilasan
only compute checksum of a local file that is not a virtual one
b120d6f 
should avoid triggering implicit hydration from within the desktop
client

triggering an implicit hydration on our own is strictly forbidden as
that is causing issues like deadlock and failed hydration attempts

Signed-off-by: Matthieu Gallien <[email protected]>
@camilasan
Add logs.
cc58f87 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add new cfapi callbacks for logging.
b82a76a 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Start reporting progress before hydration starts.
131d619 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Fix version in doc/conf.py
19e0844 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan camilasan force-pushed the bugfix/network-errors branch from 1e953f0 to 19e0844 Compare June 17, 2024 13:42
@camilasan camilasan closed this Jun 17, 2024
@camilasan camilasan deleted the bugfix/network-errors branch June 17, 2024 14:25
This was referenced Jun 17, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra left review comments

@mgallien mgallien Awaiting requested review from mgallien

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@camilasan @szaimen @nextcloud-desktop-bot @claucambra @mgallien @nextcloud-bot @skjnldsv