GUI/LIBSYNC: force login flow V2 with config setting #6261
Conversation
|
|
AppImage file: nextcloud-PR-6261-49b6a3a13d2a82b342dbdc00d0094375a6937a43-x86_64.AppImage |
Indeed, looks good! |
|
Seems some required tests are failing for unrelated reasons, can they be restarted @claucambra ? |
mickenordin
force-pushed
the
master
branch
3 times, most recently
from
c9b90b8 to
3f35720
Compare
|
@mickenordin I am confused on the state of the PR as visible in the github web UI |
Done! It should be ready to merge as far as I know. |
|
so this time I had the button to enable the run of checks |
|
@mickenordin you did a merge of master instead of a rebase |
|
I hate computers... I'll see if I can clean up this mess. |
This patch allows a user to set the config variable: forceLoginV2=true This will make the client use the browser login flow instead of the webview. This is useful for making the user experience equal on Windows, Linux and Mac. Currently only Macs use the v2 flow and it was only possible to get this behaviour in the Windows and Linux clients at build time using a CMAKE flag. The default behaviour is kept the same, and nothing changes for the user unless the flag is manually set in the config file. A setter is included in this patch, although it is not yet used in the GUI. Signed-off-by: Micke Nordin <[email protected]>
Formatting fixes Co-authored-by: Claudio Cambra <[email protected]> Signed-off-by: Micke Nordin <[email protected]>
Signed-off-by: Micke Nordin <[email protected]>
|
Ok @mgallien , how is that? |
|
@mickenordin perfectly fine |
This patch allows a user to set the config variable:
forceLoginV2=true
This will make the client use the browser login flow instead of the webview. This is useful for making the user experience equal on Windows, Linux and Mac. Currently only Macs use the v2 flow and it was only possible to get this behaviour in the Windows and Linux clients at build time using a CMAKE flag.
The default behaviour is kept the same, and nothing changes for the user unless the flag is manually set in the config file. A setter is included in this patch, although it is not yet used in the GUI.