Update stale.yml: Unify "needs info" handling with other NC repos #6246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
approved these changes
Nov 27, 2023
mgallien
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
@joshtrichards
makes sense
especially because the needsinfo stale workflow is ignoring the bug label
Unifies stale handling of bug tagged Issues with other Nextcloud repos (e.g. server and android). Signed-off-by: Josh Richards <[email protected]>
mgallien
force-pushed
the
jr-stalebot
branch
from
95c2e39 to
dbe3d42
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: nextcloud-PR-6246-dbe3d42c86af40988881867c239ecafc80bc457d-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more closely unifies stale handling of issues tagged as
bugswith other Nextcloud repos[1], by not closing issues that have merely not yet been fully reviewed while still keeping it easy for bug reports that require additional info from the reporter to auto-close if the reporter fails to provide the necessary additional information.Context:
Currently issues tagged as
bugsmust also be taggedapprovedto not be auto closed within 4 weeks in this repo.Realistically issues are not always able to be triaged for basic validity that quickly or tagging as
approvedis overlooked. Additionally, follow-up info is routinely needed/requested, so tagging asapprovedis inappropriate.This PR limits the auto-closing of
bugsto only those tagged asneeds info. Otherwise it's assumed they're valid, haven't been fully reviewed yet, or validity is still to be determined.As an aside,
enhancementsremain left alone (existing behavior). We may want to consider enablingneeds infoauto-closure support for these too (theserverrepo does this) since enhancement ideas often need further info in order to be valid... And right now in this repo they're simply left alone rather than auto-closed if there isn't any follow-up info received (unless one of us manually notices and closes the issue).[1] Server and Android repos: