maintain lock state if unlock happens during sync #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claucambra
reviewed
Dec 4, 2023
mgallien
force-pushed
the
bugfix/fixLockStateWhenUnlockHappensDuringSync
branch
from
6e84541 to
5c67c9b
Compare
claucambra
approved these changes
Dec 4, 2023
mgallien
force-pushed
the
bugfix/fixLockStateWhenUnlockHappensDuringSync
branch
from
5c67c9b to
c26dc38
Compare
currently unlock can happen during the sync in that case, it may be possible that the propagator will lose the lock state changes and override them when updating teh etag after a file has been uploaded detect that case and ensure we keep consistent state about files Signed-off-by: Matthieu Gallien <[email protected]>
mgallien
force-pushed
the
bugfix/fixLockStateWhenUnlockHappensDuringSync
branch
from
c26dc38 to
1dcde3a
Compare
|
/backport to stable-3.10 |
|
Kudos, SonarCloud Quality Gate passed!
|
|
AppImage file: nextcloud-PR-6236-1dcde3a41fc9c911d1a562d33508315829d1f89a-x86_64.AppImage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently unlock can happen during the sync
in that case, it may be possible that the propagator will lose the lock state changes and override them when updating teh etag after a file has been uploaded
detect that case and ensure we keep consistent state about files