Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/vfs toggle fix #6223

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Bugfix/vfs toggle fix #6223

merged 2 commits into from
Nov 20, 2023

Conversation

allexzander
Copy link
Contributor

No description provided.

@allexzander allexzander force-pushed the bugfix/vfs-toggle-fix branch 3 times, most recently from 193200e to 1b55c77 Compare November 15, 2023 10:05
@mgallien
Copy link
Collaborator

@allexzander how can I test ?

@allexzander
Copy link
Contributor Author

allexzander commented Nov 15, 2023 •
edited
Loading

@mgallien
the one for invalid folder alias (01 instead of 1 and 02 instead of 2) can't be tested as it is not reproducible on my end, what I did is, put a fake code that always executes and does what was in that line - the concatenation indeed results into 01 and 02 as those are 2 strings and not integers so string concatenation instead of integer arithmetic happens, so it is fixed by using proper types (2 ints and then casting the result to string)

the second part - you can test by switching to and from VFS mode, in the .cfg file, folders will toggle between Folders and FoldersWithPlaceholders

@allexzander allexzander force-pushed the bugfix/vfs-toggle-fix branch from 1b55c77 to 8dfc3bc Compare November 20, 2023 12:34
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6223-8dfc3bcc053767a873ec2085907b5549c25f5532-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@allexzander allexzander merged commit c2143b0 into master Nov 20, 2023
9 of 12 checks passed
@allexzander allexzander deleted the bugfix/vfs-toggle-fix branch November 20, 2023 15:48
@allexzander
Copy link
Contributor Author

/backport to stable-3.10

@allexzander allexzander mentioned this pull request Dec 1, 2023
Merged
@allexzander
Copy link
Contributor Author

/backport to stable-3.11

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.
4 participants
@allexzander @mgallien @nextcloud-desktop-bot @claucambra