Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/hydratation errors handling #6165

Closed
wants to merge 4 commits into from

Conversation

mgallien
Copy link
Collaborator

No description provided.

will avoid useless wrong and buggy API calls because the code would
think that there is an error when there is no error due to the missing
return in the lambda

Signed-off-by: Matthieu Gallien <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: Patch coverage is 45.45455% with 12 lines in your changes missing coverage. Please review.

Project coverage is 60.61%. Comparing base (5f9e04d) to head (9c2642f).
Report is 2288 commits behind head on master.

Files with missing lines Patch % Lines
src/libsync/vfs/cfapi/cfapiwrapper.cpp 45.45% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6165      +/-   ##
==========================================
+ Coverage   60.56%   60.61%   +0.04%     
==========================================
  Files         145      145              
  Lines       18837    18848      +11     
==========================================
+ Hits        11408    11424      +16     
+ Misses       7429     7424       -5     
Files with missing lines Coverage Δ
src/libsync/vfs/cfapi/vfs_cfapi.cpp 84.52% <ø> (ø)
src/libsync/vfs/cfapi/cfapiwrapper.cpp 74.56% <45.45%> (+1.75%) ⬆️

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6165-9c2642f7f36a3124689b0e01ba68b2bc64ca1a7f-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien
Copy link
Collaborator Author

obsolete and we do not want to merge it

@mgallien mgallien closed this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants