Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.10] Show more informative error message when VFS hydration fails. Displaya popup and put an error into activity list. More detailed logs. #6153

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #6140

… a popup and put an error into activity list. More detailed logs.

Signed-off-by: alex-z <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6153-dd1946604f93b19d39b67087365376989a02e869-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

3.8% 3.8% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #6153 (dd19466) into stable-3.10 (3392933) will increase coverage by 0.09%.
Report is 2 commits behind head on stable-3.10.
The diff coverage is 88.88%.

Additional details and impacted files
@@               Coverage Diff               @@
##           stable-3.10    #6153      +/-   ##
===============================================
+ Coverage        60.54%   60.63%   +0.09%     
===============================================
  Files              145      145              
  Lines            18807    18822      +15     
===============================================
+ Hits             11386    11413      +27     
+ Misses            7421     7409      -12     
Files Coverage Δ
src/common/vfs.h 52.38% <ø> (ø)
src/libsync/vfs/cfapi/hydrationjob.h 0.00% <ø> (ø)
src/libsync/vfs/cfapi/vfs_cfapi.cpp 84.52% <100.00%> (+0.11%) ⬆️
src/libsync/vfs/cfapi/hydrationjob.cpp 53.65% <87.50%> (+2.09%) ⬆️

... and 6 files with indirect coverage changes

@allexzander allexzander merged commit e95d9ed into stable-3.10 Oct 20, 2023
11 of 12 checks passed
@allexzander allexzander deleted the backport/6140/stable-3.10 branch October 20, 2023 16:48
@mgallien mgallien modified the milestones: 3.10.1, 3.10.2 Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants