Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libcloudproviders: Use DEFINE_VARIABLES to install in the correct directory #6137

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

tintou
Copy link
Contributor

@tintou tintou commented Oct 12, 2023

Conditionnaly require CMake 3.28 to install in the right directory.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #6137 (e7a2e66) into master (37b22c0) will decrease coverage by 0.03%.
Report is 6 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6137      +/-   ##
==========================================
- Coverage   60.48%   60.46%   -0.03%     
==========================================
  Files         145      145              
  Lines       18805    18805              
==========================================
- Hits        11374    11370       -4     
- Misses       7431     7435       +4     

see 2 files with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6137-e7a2e667e0bdc30d1bee7fb56a8a178607a9fbb6-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

…ectory

Conditionnaly require CMake 3.28 to install in the right directory.

Signed-off-by: Corentin Noël <[email protected]>
@mgallien mgallien force-pushed the tintou/pkgconfig-define-variables branch from e7a2e66 to 6e1e8a8 Compare March 20, 2024 11:28
@mgallien mgallien merged commit 23c812e into nextcloud:master Mar 20, 2024
8 of 11 checks passed
@tintou tintou deleted the tintou/pkgconfig-define-variables branch March 20, 2024 11:34
@mgallien mgallien added this to the 3.13.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants