Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chunk v2 destination header #6133

Merged
merged 4 commits into from
Oct 16, 2023
Merged

Fix chunk v2 destination header #6133

merged 4 commits into from
Oct 16, 2023

Conversation

claucambra
Copy link
Collaborator

@claucambra claucambra commented Oct 11, 2023 •
edited
Loading

Closes #6079

@claucambra claucambra self-assigned this Oct 11, 2023
@claucambra
Copy link
Collaborator Author

/backport to stable-3.10

@mgallien mgallien force-pushed the bugfix/chunk-v2-dest-header branch from e51fba5 to 91a4639 Compare October 11, 2023 07:41
@codecov
Copy link

codecov bot commented Oct 11, 2023 •
edited
Loading

Codecov Report

Merging #6133 (f6140f5) into master (37b22c0) will decrease coverage by 0.01%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6133      +/-   ##
==========================================
- Coverage   60.48%   60.47%   -0.01%     
==========================================
  Files         145      145              
  Lines       18805    18814       +9     
==========================================
+ Hits        11374    11378       +4     
- Misses       7431     7436       +5
Files Coverage Δ
src/common/utility.cpp 74.53% <100.00%> (+0.23%) ⬆️
src/common/utility.h 0.00% <ø> (ø)
src/libsync/propagateupload.h 30.35% <ø> (ø)
src/libsync/propagateuploadng.cpp 85.05% <100.00%> (+0.32%) ⬆️

... and 2 files with indirect coverage changes

@claucambra claucambra force-pushed the bugfix/chunk-v2-dest-header branch 2 times, most recently from 04f2458 to eb220d9 Compare October 11, 2023 08:48
@claucambra claucambra mentioned this pull request Oct 11, 2023
Closed
8 tasks
@mgallien mgallien force-pushed the bugfix/chunk-v2-dest-header branch from eb220d9 to f6140f5 Compare October 16, 2023 08:11
mgallien
mgallien approved these changes Oct 16, 2023
View reviewed changes
src/libsync/propagateuploadng.cpp Show resolved Hide resolved
@mgallien mgallien enabled auto-merge October 16, 2023 08:12
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6133-f6140f5b5f4ade1e021f329e62530ace038edd16-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien merged commit 4ca69f6 into master Oct 16, 2023
12 of 13 checks passed
@mgallien mgallien deleted the bugfix/chunk-v2-dest-header branch October 16, 2023 09:06
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 16, 2023
Merged
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgallien mgallien mgallien approved these changes

@camilasan camilasan Awaiting requested review from camilasan

@allexzander allexzander Awaiting requested review from allexzander

Assignees

@claucambra claucambra

Labels
None yet
Projects
None yet
Milestone
3.11.0
3 participants
@claucambra @nextcloud-desktop-bot @mgallien