Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve names of CI checks and do not run them on merges to master #6089

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

mgallien
Copy link
Collaborator

not convinced it is needed to run the checks after a merge to master branch in addition to running them before merging a PR

not convinced it is needed to run the checks after a merge to master
branch in addition to running them before merging a PR

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the ci/betterNamesForCiChecks branch from 0cda523 to bb09bc6 Compare September 25, 2023 09:27
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6089-bb09bc67fc94080f6412491bc7f6a863d37d096a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

❗ No coverage uploaded for pull request base (master@a91c96b). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #6089   +/-   ##
=========================================
  Coverage          ?   60.33%           
=========================================
  Files             ?      145           
  Lines             ?    18800           
  Branches          ?        0           
=========================================
  Hits              ?    11343           
  Misses            ?     7457           
  Partials          ?        0           

@mgallien mgallien merged commit b4a5717 into master Sep 25, 2023
12 of 13 checks passed
@mgallien mgallien deleted the ci/betterNamesForCiChecks branch September 25, 2023 14:16
@mgallien
Copy link
Collaborator Author

/backport to stable-3.10

@backportbot-nextcloud
Copy link

The backport to stable-3.10 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable-3.10
git pull origin stable-3.10

# Create the new backport branch
git checkout -b fix/foo-stable-3.10

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable-3.10

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants