Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/activity list fixes #6064

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Bugfix/activity list fixes #6064

merged 1 commit into from
Sep 22, 2023

Conversation

allexzander
Copy link
Contributor

@allexzander allexzander commented Sep 15, 2023 •
edited
Loading

@allexzander allexzander linked an issue Sep 15, 2023 that may be closed by this pull request
Activities design review #5933
Closed
4 tasks
claucambra
claucambra requested changes Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a full review, some small comments

src/gui/tray/NCProgressBar.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
@allexzander
Copy link
Contributor Author

@jancborchardt @nimishavijay Design approval required. Changes are shown in 2 videos and a screenshot attached.

@allexzander
Copy link
Contributor Author

Not a full review, some small comments

fixed

nimishavijay
nimishavijay requested changes Sep 18, 2023
View reviewed changes
Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice now! Only point:
Instead of button instantly disappearing, it could have a 0.25s transition where it fades out, other than that it looks great! :)

claucambra
claucambra requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full review, mostly nitpicks and small changes

src/gui/tray/sortedactivitylistmodel.cpp Outdated Show resolved Hide resolved
src/gui/tray/syncstatussummary.cpp Outdated Show resolved Hide resolved
src/gui/tray/syncstatussummary.cpp Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
src/gui/tray/ActivityList.qml Outdated Show resolved Hide resolved
src/gui/tray/ActivityList.qml Outdated Show resolved Hide resolved
src/gui/tray/ActivityList.qml Outdated Show resolved Hide resolved
@allexzander
Copy link
Contributor Author

Super nice now! Only point: Instead of button instantly disappearing, it could have a 0.25s transition where it fades out, other than that it looks great! :)
@nimishavijay
Done, kindly check and approve

new_activities_button_disappearing_with_fade.mp4

@nimishavijay
Copy link
Member

Ah no that is not what I meant! I meant that it can be the same as the original screenshot, but instead of the button disappearing instantly it can fade out, do you get what I mean? :)

@codecov
Copy link

codecov bot commented Sep 19, 2023 •
edited
Loading

Codecov Report

Merging #6064 (1e9fa0a) into master (a045dd7) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6064   +/-   ##
=======================================
  Coverage   60.33%   60.33%           
=======================================
  Files         145      145           
  Lines       18793    18793           
=======================================
  Hits        11338    11338           
  Misses       7455     7455

@allexzander allexzander force-pushed the bugfix/activity-list-fixes branch from 14b828e to 0381813 Compare September 19, 2023 15:29
claucambra
claucambra reviewed Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is pretty close, just a few more comments

src/gui/tray/ActivityList.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
src/gui/tray/Window.qml Outdated Show resolved Hide resolved
@allexzander allexzander force-pushed the bugfix/activity-list-fixes branch 2 times, most recently from 14b828e to 4869527 Compare September 20, 2023 10:12
@allexzander allexzander force-pushed the bugfix/activity-list-fixes branch from 5b5dff9 to 15cf06e Compare September 22, 2023 09:13
@allexzander
Copy link
Contributor Author

/backport to stable-3.10

@allexzander
Activity list fixes and improvements. Adjusted sorting to show intera…
1e9fa0a 
…ctive and security activities always on top (after errors). Added button to scroll up when new activity arrives. Improved sync status scrollbar.

Signed-off-by: alex-z <[email protected]>
@allexzander allexzander force-pushed the bugfix/activity-list-fixes branch from 15cf06e to 1e9fa0a Compare September 22, 2023 13:28
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6064-1e9fa0a1322e597bbcc0718960d6a0e27c74ff18-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

42.4% 42.4% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@allexzander allexzander merged commit 767af53 into master Sep 22, 2023
12 of 13 checks passed
@allexzander allexzander deleted the bugfix/activity-list-fixes branch September 22, 2023 15:19
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Sep 22, 2023
Closed
@mgallien mgallien added this to the 3.11.0 milestone Dec 12, 2023
@PhilippSchlesinger PhilippSchlesinger mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien Awaiting requested review from mgallien

@camilasan camilasan Awaiting requested review from camilasan

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

Activities design review
5 participants
@allexzander @nimishavijay @nextcloud-desktop-bot @claucambra @mgallien