Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-3.10] do not check every 5 seconds files with infinite timeout (= 0) #6060

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #6059

@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.10.0 milestone Sep 14, 2023
@mgallien mgallien enabled auto-merge September 14, 2023 21:02
we want to schedule a new sync attempt if a file is likely to have been
unlocked due to timeout expiring on server

but if the timeout is null (equal to 0), there will be no timeout on
server and no automated unlocking, so do not schedule a sync every 5
seconds to check for it

Signed-off-by: Matthieu Gallien <[email protected]>
@mgallien mgallien force-pushed the backport/6059/stable-3.10 branch from 7601e74 to d299e57 Compare September 14, 2023 21:17
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #6060 (d299e57) into stable-3.10 (3f0a3ae) will increase coverage by 0.15%.
Report is 1 commits behind head on stable-3.10.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           stable-3.10    #6060      +/-   ##
===============================================
+ Coverage        60.27%   60.42%   +0.15%     
===============================================
  Files              145      145              
  Lines            18866    18868       +2     
===============================================
+ Hits             11371    11401      +30     
+ Misses            7495     7467      -28     
Files Changed Coverage Δ
src/libsync/discovery.cpp 86.42% <100.00%> (+0.02%) ⬆️

... and 7 files with indirect coverage changes

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6060-d299e579e6bb9dce3302d673010bf58a7131812c-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@mgallien mgallien merged commit d86bdd0 into stable-3.10 Sep 14, 2023
12 checks passed
@mgallien mgallien deleted the backport/6059/stable-3.10 branch September 14, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants